Potential fix for code scanning alert no. 254: Code injection#55
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… through an exception' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
brokermr810
marked this pull request as ready for review
April 22, 2026 06:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/brokermr810/QuantDinger/security/code-scanning/254
通用修复思路:对所有来自 HTTP 的脚本代码,在进入 service 执行链前进行显式安全校验;未通过即返回 400,阻断 tainted 数据到
exec。保留safe_exec_with_validation内部校验作为第二道防线。本次最佳单一修复方案(不改变既有功能):
backend_api_python/app/routes/backtest.py中增加对indicator_code的执行前校验(调用app.utils.safe_exec.validate_code_safety)。indicator_code后、调用backtest_service.run/run_multi_timeframe前,若校验失败直接返回统一错误响应。需要的实现要点:
from app.utils.safe_exec import validate_code_safetyindicator_code读取之后)Suggested fixes powered by Copilot Autofix. Review carefully before merging.